New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consul): Adds a data source to retrieve kv pairs under a specified path #10353
feat(consul): Adds a data source to retrieve kv pairs under a specified path #10353
Conversation
Hi @samber Thanks for the work here - looks like this doesn't build - any chance you could have a look at it? Thanks Paul |
@stack72 sorry for the late fix. This is working well ;) Should we deprecate reads from consul_key_prefix resource ? |
@stack72 any ideas when this PR can be merged? |
up ? |
Having this PR checked and merged would be very helpful to us @stack72 :) |
Hi @samber Please can you rebase this PR? I can then start to review it and see if we can get it merged ASAP Thanks Paul |
// in case it was read from the provider | ||
d.Set("datacenter", dc) | ||
|
||
d.SetId("-") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no Id, then we should use something like:
d.SetId(time.Now().UTC().String())
Note that |
Hi folks! Now that terraform 0.12 is released, we are undertaking a general GH issue/PR cleanup. The providers now live in their own repositories, so any new issues or PRs should be opened there. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Hi guys,
Example:
Read have been deprecated in resource consul_keys after adding the consul_keys data source. I think we should do the same for the resource consul_key_prefix. This data source should be the correct way to get data.