Fix #7690: Update vendored cloudflare-go library

[mwarkentin]

• DNS record change is not reflected in Cloudflare #7690
• Problems updating DNS record cloudflare/cloudflare-go#97
• Bugfix for UpdateDNSRecord cloudflare/cloudflare-go#98

There was an upstream fix to allow updating of DNS record name fields.

A few other comment updates, but that's it.

Not sure if an upstream bug fix requires an acceptance test. I started working on that initially, but I could use some guidance on what I was trying to do in #10846.

[stack72]

Hi @mwarkentin

Thanks so much for the work here - this LGTM! I have just ran all of the tests:

% make testacc TEST=./builtin/providers/cloudflare
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/24 14:36:08 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/cloudflare -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestCloudFlareRecordMigrateState
--- PASS: TestCloudFlareRecordMigrateState (0.01s)
=== RUN   TestAccCloudFlareRecord_Basic
--- PASS: TestAccCloudFlareRecord_Basic (4.25s)
=== RUN   TestAccCloudFlareRecord_Apex
--- PASS: TestAccCloudFlareRecord_Apex (3.38s)
=== RUN   TestAccCloudFlareRecord_Proxied
--- PASS: TestAccCloudFlareRecord_Proxied (3.68s)
=== RUN   TestAccCloudFlareRecord_Updated
--- PASS: TestAccCloudFlareRecord_Updated (4.83s)
=== RUN   TestAccCloudFlareRecord_forceNewRecord
--- PASS: TestAccCloudFlareRecord_forceNewRecord (5.14s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/cloudflare	21.306s

[mwarkentin]

@stack72 Nice, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.