provider/aws: Add support for policy to AWS provider assume_role #11501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #11461 This will allow the user to pass a policy to further restrict the use of AssumeRole. It is important to note that it will NOT allow an expansion of access rights
stack72
force-pushed
the
f-aws-assumerole-policy
branch
from
7042b7c
to
50e6c68
Compare
jen20
approved these changes
Jan 29, 2017
| @@ -146,8 +146,8 @@ func GetCredentials(c *Config) (*awsCredentials.Credentials, error) { | |||
|
|
|||
| // Otherwise we need to construct and STS client with the main credentials, and verify | |||
| // that we can assume the defined role. | |||
| log.Printf("[INFO] Attempting to AssumeRole %s (SessionName: %q, ExternalId: %q)", | |||
| c.AssumeRoleARN, c.AssumeRoleSessionName, c.AssumeRoleExternalID) | |||
| log.Printf("[INFO] Attempting to AssumeRole %s (SessionName: %q, ExternalId: %q, Policy: %q)", | |||
There was a problem hiding this comment.
We might want to consider logging the policy on a separate line here as it will be quoted JSON?
stack72
added a commit
that referenced
this pull request
Jan 29, 2017
) Fixes: #11461 This will allow the user to pass a policy to further restrict the use of AssumeRole. It is important to note that it will NOT allow an expansion of access rights
arcadiatea
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
Feb 9, 2017
…hicorp#11501) Fixes: hashicorp#11461 This will allow the user to pass a policy to further restrict the use of AssumeRole. It is important to note that it will NOT allow an expansion of access rights
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11461
This will allow the user to pass a policy to further restrict the use
of AssumeRole. It is important to note that it will NOT allow an
expansion of access rights