state/remote: export ClientLocker, test for implementation #11978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds unit tests (that will fail at compile time) if various structs don't implement the right interfaces for locking
jbardin
approved these changes
Feb 15, 2017
state/remote/remote.go
Outdated
| // backend to enable state lock/unlock. | ||
| type ClientLocker interface { | ||
| Client | ||
|
|
There was a problem hiding this comment.
would it make sense to just embed state.Locker?
There was a problem hiding this comment.
That's a fair point since the APIs are the same right now. Will do.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit tests (that will fail at compile time) if various structs
don't implement the right interfaces for locking