provider/aws: Add Cognito Identity Pool Roles Attachment

[Ninir]

Description

This adds the AWS Cognito Identity Roles association resource, based on the following API: http://docs.aws.amazon.com/cognitoidentity/latest/APIReference/API_SetIdentityPoolRoles.html

Related issues

• Missing AWS Cognito Support #8309

Tests

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCognitoIdentityPoolRolesAttachment_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/21 20:27:48 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCognitoIdentityPoolRolesAttachment_ -timeout 120m
=== RUN   TestAccAWSCognitoIdentityPoolRolesAttachment_basic
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_basic (59.64s)
=== RUN   TestAccAWSCognitoIdentityPoolRolesAttachment_roleMappings
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_roleMappings (103.70s)
=== RUN   TestAccAWSCognitoIdentityPoolRolesAttachment_roleMappingsWithError
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_roleMappingsWithError (17.80s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    181.171s

TODOs

• Add the Cognito Identity Roles Resource
• Add Cognito Identity Roles Resource validation
• Add the Cognito Identity Roles Resource documentation
• Add Cognito Identity Roles Resource test cases

[radeksimko]

Hi @Ninir
thanks for the PR.
Would you mind splitting this into at least 3 PRs to make the review a bit easier? 😅

• vendor updates - I think we could merge that one pretty much straight away and then you can rebase and work with less LOC in your other PRs
• aws_cognito_identity_pool
• aws_cognito_identity_pool_roles_attachment

Thanks.

[Ninir]

Hi @radeksimko Sure! Didnt want to have them merged separately since the roles attachment dépends on the cognito pool, but will add the WIP label + description. Will be able to do it next tuesday (no computer until then!) :)

…

Le 12 avr. 2017 à 06:33, Radek Simko ***@***.***> a écrit : Hi @Ninir would you mind splitting this into at least 3 PRs to make the review a bit easier? 😅 vendor updates - I think we could merge that one pretty much straight away and then you can rebase and work with less LOC in your other PRs aws_cognito_identity_pool aws_cognito_identity_pool_roles_attachment Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Ninir]

@radeksimko Kind of ready on my side :)

[Ninir]

At the moment, as token is required and has only 2 possibles values (Token or Rules), this seems required too.
The API states that this is Optional though.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.