Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge config.Terraform fields in config.Append #12942

Merged
merged 2 commits into from
Mar 22, 2017
Merged

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Mar 21, 2017

Ensure that fields set in an earlier Terraform config block aren't
removed by Append when encountering another Terraform block. When
multiple blocks contain the same field, the later one still wins.

Fixes #12905

Ensure that fields set in an earlier Terraform config block aren't
removed by Append when encountering another Terraform block. When
multiple blocks contain the same field, the later one still wins.
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to bring this logic to merge.go too.

@jbardin
Copy link
Member Author

jbardin commented Mar 22, 2017

🤦‍♂️ of course! Added!

@jbardin jbardin merged commit 579e15c into master Mar 22, 2017
@jbardin jbardin deleted the jbardin/GH-12905 branch March 22, 2017 13:11
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform required_version prevents s3 remote backend initialization
2 participants