Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backend/swift docs #19007

Merged
merged 6 commits into from Nov 8, 2018
Merged

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Oct 4, 2018

The docs contained an error telling people to use expire_after when they really wanted object versioning. This error is actually quite damaging because instead of not even retaining versions of the state, it is outright deleted after a given amount of time. Fixed up the examples and other bits to not use deprecated items. Fixed bad links to the OpenStack Swift project. Added more links to the OpenStack Swift project. fixes #19005

@cardoe
Copy link
Contributor Author

cardoe commented Oct 28, 2018

ping @tombuildsstuff since you marked up the issue I reported. This PR fixes that.

@cardoe
Copy link
Contributor Author

cardoe commented Oct 28, 2018

Also ping @mildwonkey since I see you review docs PRs often.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides one minor question this otherwise LGTM 👍

website/docs/backends/types/swift.html.md Show resolved Hide resolved
cardoe and others added 6 commits November 6, 2018 18:18
Update the examples and docs to not directly reference deprecated
fields.
The links to the OpenStack Swift documentation were broken due to
changes on the OpenStack website.
Provide a link to the OpenStack Swift docs for the object expiration
feature that is used by the `expire_after` field.
The displayed link said `expire_after` but really is a link to
`archive_container` so update the link to read the right data.
fixes hashicorp#19005
Since object versioning is a best practice the docs should have all the
examples containing it by default.
If the user uses the auto-expire value in the backend/swift settings
then swift will automatically delete their Statefile which is likely
something the user doesn't want given how Terraform works.
@cardoe
Copy link
Contributor Author

cardoe commented Nov 7, 2018

I've rebased it to hopefully make merging this easier. @radeksimko I'd appreciate some comments. The documentation on the website will literally delete tfstate for OpenStack backend users.

Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mildwonkey mildwonkey merged commit 1be0974 into hashicorp:master Nov 8, 2018
@cardoe cardoe deleted the fix-swift-backend-docs branch November 13, 2018 06:12
@cardoe
Copy link
Contributor Author

cardoe commented Nov 13, 2018

Any special trick that needs to get done to get the website to re-render the docs?

@cardoe
Copy link
Contributor Author

cardoe commented Nov 13, 2018

I can make a PR against branch v0.11

cardoe pushed a commit to cardoe/terraform that referenced this pull request Dec 18, 2018
Fix backend/swift docs

(cherry picked from commit 1be0974)
mildwonkey pushed a commit that referenced this pull request Dec 20, 2018
Fix backend/swift docs

(cherry picked from commit 1be0974)
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backend/swift docs appear to be incorrect about object versioning
3 participants