core: Don't panic if NodeApplyableResourceInstance has no config #21310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a "should never happen" case, because we shouldn't ever have resources in the plan that aren't in the configuration, but since we've got a report of a crash here (which went away before we got a chance to debug it) here's just an extra guard to ensure that we'll still exit gracefully in that case. If we see this error crop up again in future, it'd be nice to gather a full trace log so we can see what GraphNodeAttachResourceConfig did and why it did not attach a configuration.
jbardin
approved these changes
May 14, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "should never happen" case, because we shouldn't ever have resources in the plan that aren't in the configuration, but since we've got a report of a crash here (which went away before we got a chance to debug it) here's just an extra guard to ensure that we'll still exit gracefully in that case.
If we see this error crop up again in future, it'd be nice to gather a full trace log so we can see what
GraphNodeAttachResourceConfigdid and why it did not attach a configuration.This closes #21258, but it does not fix it: instead, it hopefully arranges for us to get more information (the resource address, in particular) in a subsequent bug report if this manages to crop up again.