modules: update Azure deps to latest #22247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies - I had meant to push this to my own fork but it ended up here. 😕 Leaving it open so we don't have to re-open the PR. |
tamalsaha
reviewed
Jul 29, 2019
vancluever
force-pushed
the
v0.12.5-updated-azure
branch
from
2893510
to
cd14582
Compare
|
@vancluever Could you resolve conflicts on this and #22248 and then request review? |
The dependencies here are dated and are causing conflicts with the ACME provider, namely the version of the top-level autorest package. This explicitly updates the Azure SDK and autorest packages, with the separately versioned sub-packages being added automatically.
vancluever
force-pushed
the
v0.12.5-updated-azure
branch
from
cd14582
to
92c46c5
Compare
|
@pselle done! |
|
FWIW, LGTM. |
mildwonkey
approved these changes
Aug 1, 2019
vancluever
added a commit
to vancluever/terraform-provider-acme
that referenced
this pull request
Aug 10, 2019
This updates lego to its v3 release, which includes modules. Also, it updates Terraform to the latest HEAD in master to address dependency issues that arise as a result of this change, see hashicorp/terraform#22247.
vancluever
added a commit
to vancluever/terraform-provider-acme
that referenced
this pull request
Aug 12, 2019
This updates lego to its v3 release, which includes modules. Also, it updates Terraform to the latest HEAD in master to address dependency issues that arise as a result of this change, see hashicorp/terraform#22247.
vancluever
added a commit
to vancluever/terraform-provider-acme
that referenced
this pull request
Aug 12, 2019
This updates lego to its v3 release, which includes modules. Also, it updates Terraform to the latest HEAD in master to address dependency issues that arise as a result of this change, see hashicorp/terraform#22247.
radeksimko
added a commit
that referenced
this pull request
Aug 20, 2019
This is to allow Terraform providers to upgrade to at least one more minor version of the plugin SDK without major UX hiccups. This concludes (unsuccessful) experiments involving upgrades to SDK with Azure/go-autorest#455 Even with that patch all providers still experience broken UX as described in #22490 This downgrade reduces the uncomfort to only a handful of providers from >100s. The affected providers more or less directly depend on Azure SDK(s), which is ~8. Affected providers practically cannot consume Terraform Plugin SDK with this patch (downgraded Azure SDKs) and can just wait for extracted Terraform Plugin SDK which is planned to be released soon. This reverts the following PRs: - #22247 - #22248 - #22524 - #22525 and it is otherwise result of the following commands ``` go get github.com/Azure/azure-sdk-for-go@v21.3.0 go get github.com/hashicorp/go-azure-helpers@166dfd221bb2 go mod tidy ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies here are dated and are causing conflicts with the
ACME provider, namely the version of the top-level autorest package.
This explicitly updates the Azure SDK and autorest packages, with the
separately versioned sub-packages being added automatically.