Packet bare metal cloud hosting platform provider #2260
Conversation
| ) | ||
|
|
||
| const ( | ||
| consumerToken = "aZ9GmqHTPtxevvFq9SK3Pi2yr9YCbRzduCSXF2SNem5sjB91mDq7Th3ZwTtRqMWZ" |
There was a problem hiding this comment.
it is used by us to identify the source of a request, this is the one we issued for terraform. basically, it is not required, but if it is not present then we rate limit the requests. it is also not used for authentication, that is what the end user's auth token is used for. does that make sense?
|
Also, I have a test for the device resource, but it requires a project id, and I'm not sure the best way to inject that into the config variables. If someone can point me to an example I'll drop that in as well, otherwise will take a deeper look later this week. |
|
@radeksimko would be nice to get it merged to master, so it can be released with the next terraform version. |
|
@phinze looks ready for 👀, has tests & doc too! |
|
|
||
| log.Printf("[INFO] Device ID: %s", d.Id()) | ||
|
|
||
| _, err = WaitForDeviceAttribute(d, "active", []string{"provisioning"}, "state", meta) |
There was a problem hiding this comment.
@crunchywelch Should you perhaps add "queued" to the pending states?
|
This is looking good! I'll pull it in as-is and improvements can be made on separate PRs.
@crunchywelch generally for tests that require special settings like that we just have test-specific environment variables and skip the test with a message if they're not set. |
Packet bare metal cloud hosting platform provider
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
First effort on this, let me know if you'd like to have tests written or if this is a good place to start with the initial PR. Thanks!