Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't connect module closers to destroy nodes #26186

Merged
merged 1 commit into from Sep 9, 2020
Merged

don't connect module closers to destroy nodes #26186

merged 1 commit into from Sep 9, 2020

Commits on Sep 9, 2020

  1. don't connect module closers to destroy nodes 

    One of the tenants of the graph transformations is that resource destroy
nodes can only be ordered relative to other resources, and can't be
referenced directly. This was broken by the module close node which
naively connected to all module nodes, creating cycles in some cases
when edges are reversed from CreateBeforeDestroy.
    @jbardin
    jbardin committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    c9e581e View commit details
    Browse the repository at this point in the history