Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Update module-registry-protocol.html.md #26639

Merged
merged 2 commits into from Oct 28, 2020

Conversation

alevinetx
Copy link
Contributor

1: There is a mismatch in the segment labels for the version query URL (system vs provider)
2: There is a discrepancy between the documentation and the actual generated request for retrieving module source code (URL segments 4 vs 3)

  • There is no segment for "provider"

1: There is a mismatch in the segment labels for the version query URL (system vs provider)
2: There is a discrepancy between the documentation and the actual generated request for retrieving module source code (URL segments 4 vs 3)
 - There is no segment for "provider"
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 20, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #26639 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
terraform/node_resource_plan.go 97.19% <0.00%> (+1.86%) ⬆️

Copy link
Contributor

@justincampbell justincampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I believe this correctly identifies that the :system and :provider variables are duplicated in the URLs and Parameters. :provider is the canonical name for this field, so if you can replace :system with :provider in your changes, we can merge this.

Changed ```:system``` to ```:provider``` for versions and source API URLs
@pkolyvas pkolyvas changed the title Update module-registry-protocol.html.md website: Update module-registry-protocol.html.md Oct 22, 2020
@alevinetx
Copy link
Contributor Author

@justincampbell I wanted to make sure I did everything to fix and trigger that it's ready for you, and that it's just waiting on you, rather than I haven't done something needed.
thanks !

Copy link
Contributor

@justincampbell justincampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@justincampbell justincampbell merged commit 66393bb into hashicorp:master Oct 28, 2020
@ghost
Copy link

ghost commented Nov 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants