Unmark values before showing in JSON #26739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pselle
force-pushed
the
pselle/show-json
branch
2 times, most recently
from
c31c6c7
to
b3f669a
Compare
Codecov Report
|
pselle
added
the
0.14-backport
This prevents "sensitive" values from unintentionally showing as nil when running terraform show -json
pselle
force-pushed
the
pselle/show-json
branch
from
b3f669a
to
66091ae
Compare
alisdair
approved these changes
Oct 28, 2020
| @@ -100,7 +99,10 @@ type resource struct { | |||
| // resource, whose structure depends on the resource type schema. | |||
| type attributeValues map[string]interface{} | |||
|
|
|||
| func marshalAttributeValues(value cty.Value, schema *configschema.Block) attributeValues { | |||
| func marshalAttributeValues(value cty.Value) attributeValues { | |||
There was a problem hiding this comment.
I appreciate this incidental clean-up! 🙏
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents "sensitive" values from unintentionally showing as nil when running terraform show -json. Also adjusts the signature of a function to remove an unused argument.
Closes #26737