Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable single address locking in HTTP backend, fixes #23777 #26815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lenaing
Copy link

@lenaing lenaing commented Nov 4, 2020

Hi,

This enable single remote endpoint locking, trying to fix #23777.

Now an HTTP backend can just be

terraform {
  backend "http" {
    address = "http://myrestapi.example.com/foo"
    locking = true
  }
}

And the address will then be used for both LOCK and UNLOCK operations.

If lock_address or unlock_address are specified, the HTTP backend use them accordingly as usual, enabling one to override them if required.

Kind regards,

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #26815 into master will increase coverage by 0.01%.
The diff coverage is 54.54%.

Impacted Files Coverage Δ
backend/remote-state/http/backend.go 82.73% <54.54%> (-2.43%) ⬇️
states/statefile/version4.go 57.96% <0.00%> (-0.24%) ⬇️
terraform/node_resource_apply_instance.go 75.78% <0.00%> (+0.78%) ⬆️
terraform/eval_diff.go 67.43% <0.00%> (+0.91%) ⬆️
terraform/node_resource_plan.go 97.16% <0.00%> (+1.88%) ⬆️

Base automatically changed from master to main February 24, 2021 18:01
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow single address in http backend for locking
4 participants