Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor provisioners #26938

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Nov 16, 2020

Removes the builtin chef, habitat, puppet, and salt-masterless provisioners, which were deprecated. Updated the documentation for these provisioners to clarify that they have been removed from (what will be) later versions of Terraform. This PR has no impact on the plugin layer/side-loading provisioners.

A side effect of this PR is updating the ./scripts/fmtcheck script for correctness, as it previously directed you to keep running that check, which doesn't do any formatting (removing this code involved updating the internal plugin list, which is generated code).

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #26938 (e39e0e3) into master (c1d3040) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
configs/provisioner.go 68.68% <100.00%> (+0.31%) ⬆️
scripts/generate-plugins.go 45.91% <0.00%> (-1.03%) ⬇️

@pselle pselle marked this pull request as ready for review November 16, 2020 19:38
@pselle pselle force-pushed the pselle/remove-vendor-provisioners branch 2 times, most recently from 1bae2e9 to 6a4abcf Compare November 16, 2020 19:50
@pselle pselle requested a review from a team November 16, 2020 20:20
Makefile Outdated Show resolved Hide resolved
Remove chef, habitat, puppet, and salt-masterless provsioners,
which follows their deprecation. Update the documentatin for these
provisioners to clarify that they have been removed from later versions
of Terraform. Adds the fmt Make target back and updates fmtcheck script
for correctness.
@pselle pselle changed the title Remove vendor provisioners (and add fmt Make target) Remove vendor provisioners Nov 17, 2020
@pselle pselle force-pushed the pselle/remove-vendor-provisioners branch from 6a4abcf to e39e0e3 Compare November 17, 2020 16:22
@pselle pselle merged commit c6ab9b1 into master Dec 2, 2020
@pselle pselle deleted the pselle/remove-vendor-provisioners branch December 2, 2020 16:48
@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants