cliconfig: Move HCL 1.0-based language out of the way #27067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been continuing to maintain the HCL 1-based CLI configuration language to keep compatibility with prior versions, but the HCL 1 API is constraining and it's annoying to have both versions of HCL in Terraform at once. This commit doesn't change any user-visible behavior but it does rename a bunch of things in the cliconfig package to include the word "Legacy" so that we can gradually build out an HCL 2 based new implementation alongside and eventually support them both together. The plan to support them both at once is to also switch over to using OS-standard configuration file locations (like XDG Base Directory on Linux) at the same time and treat the new locations as an opt-in for the new language variant, with both continuing to be supported for the forseeable future but the legacy one likely becoming increasingly more deprecated as it ages.
Codecov Report
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been continuing to maintain the HCL 1-based CLI configuration language to keep compatibility with prior versions, but the HCL 1 API is constraining and it's annoying to have both versions of HCL in Terraform at once.
In this PR I'm hoping to gradually, as time allows, build a new HCL 2 based implementation alongside the existing one, with the intent of supporting them both for a while after and then hopefully eventually phasing out the legacy configuration.
However, this is not a high-priority effort so I'll be moving it forward slowly only to the extent that I have some spare moments around other work. For now it'll remain a draft until there's something more concrete to share.