Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Avoid double-marking variables into v0.14 #27148

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #27131 to be assessed for backporting due to the inclusion of the label 0.14-backport.

The below text is copied from the body of the original PR.


It is possible, say with multiple layers of sensitive variables, to "double-mark" a variable. Add a check to ensure this does not happen.

Fixes #27095

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #27148 (d41b16f) into v0.14 (bde4487) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
terraform/evaluate.go 53.30% <100.00%> (ø)
terraform/eval_diff.go 67.52% <0.00%> (-0.94%) ⬇️
terraform/node_resource_apply_instance.go 75.00% <0.00%> (-0.80%) ⬇️
dag/marshal.go 54.79% <0.00%> (+1.36%) ⬆️

@pselle pselle merged commit e63ccd6 into v0.14 Dec 7, 2020
@pselle pselle deleted the backport/pselle/double-marks/amazingly-maximum-monitor branch December 7, 2020 22:46
@ghost
Copy link

ghost commented Jan 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants