Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: Fix terraform show not outputting child_modules properly in certain circumstances #27352

Merged
merged 3 commits into from Jan 11, 2021

Conversation

cube2222
Copy link
Contributor

This is a proposed fix for #27351

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 21, 2020

CLA assistant check
All committers have signed the CLA.

@cube2222 cube2222 changed the title Fix terraform show not outputting child_modules properly in certain circumstances command: Fix terraform show not outputting child_modules properly in certain circumstances Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #27352 (72970f5) into master (c0e37a7) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Impacted Files Coverage Δ
command/jsonstate/state.go 58.86% <75.00%> (+9.61%) ⬆️
communicator/communicator.go 77.19% <0.00%> (-3.51%) ⬇️
states/statefile/version4.go 57.96% <0.00%> (-0.24%) ⬇️
terraform/evaluate.go 52.89% <0.00%> (+0.41%) ⬆️
dag/marshal.go 63.49% <0.00%> (+1.58%) ⬆️
terraform/node_resource_plan.go 98.05% <0.00%> (+1.94%) ⬆️

Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix @cube2222 , looks great!

@mildwonkey mildwonkey merged commit b496557 into hashicorp:master Jan 11, 2021
@cube2222
Copy link
Contributor Author

Thanks for the quick merge, appreciate it!

aliscott pushed a commit to aliscott/terraform that referenced this pull request Feb 10, 2021
…certain circumstances (hashicorp#27352)

* Add test for module nesting without resources.

* Add test

* Fix showing resources when a module has no resources, only submodules.
@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants