Add support for plugin protocol v6 #27826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR turns on support for plugin protocol v6. A provider can advertise itself as supporting protocol version 6 and terraform will use the correct client. Todo: The "unmanaged" providers functionality does not support protocol version, so at the moment terraform will continue to assume that "unmanaged" providers are on protocol v5. This will require some upstream work on go-plugin (I believe). I would like to convert the builtin providers to use protocol v6 in a future PR; however it is not necessary until we remove protocol v6.
Codecov Report
|
mildwonkey
commented
Feb 18, 2021
| @@ -57,7 +52,7 @@ func pluginSet(opts *ServeOpts) map[int]plugin.PluginSet { | |||
|
|
|||
| // add the new protocol versions if they're configured | |||
| if opts.GRPCProviderFunc != nil { | |||
| plugins[5] = plugin.PluginSet{} | |||
| plugins[6] = plugin.PluginSet{} | |||
There was a problem hiding this comment.
🙈 nothing to see here this was correct all along
jbardin
approved these changes
Feb 18, 2021
radeksimko
approved these changes
Feb 19, 2021
- copied grpcwrap and made a version that returns protocol v6 provider - copied the test provider, provider-simple, and made a version that's using protocol v6 with the above fun - added an e2etest
mildwonkey
force-pushed
the
mildwonkey/multipass
branch
from
4237d62
to
d403e44
Compare
paddycarver
approved these changes
Feb 20, 2021
There was a problem hiding this comment.
This seems right to me! I have more investigation I want to do with @mildwonkey about protocol version selection, but that almost certainly exists outside the scope of this PR.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on support for plugin protocol v6. A provider can
advertise itself as supporting protocol version 6 and terraform will
use the correct client.
I apologize for the noisy name changes in
plugin6which should have been caught in the previous PR; I'd inadvertently left out a test file with a load-bearing interface assertion.A few notable TODOs which are outside of the scope of this PR:
The "unmanaged" providers functionality does not support protocol
version, so at the moment terraform will continue to assume that
"unmanaged" providers are on protocol v5. This will require some
upstream work on go-plugin (I believe).
I would like to convert the builtin providers to use protocol v6 in a
future PR; however it is not necessary until we remove protocol v6.
T E S T I N G!
It's easy to prove that this is working for providers using protocol v5 (the e2e and other tests would blow up if I'd gotten that wrong!) but my next step will likely involve adding an internal test provider that uses protocol v6 and writing tests that use both in one config.