Better planing of unknown dynamic blocks #28424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow any dynamic blocks that are fixed up as a blocktoattr still decode into an unknown value.
Dynamic blocks with unknown for_each expressions are now decoded into an unknown value rather than using a sentinel object with unknown and null attributes. This will allow providers to precisely plan the block values, rather than trying to heuristically paper over the incorrect plans when dynamic is in use.
The new hcldec dynamic block behavior no longer tried to validate MinItems and MaxItems when the number of values is unknown.
Codecov Report
|
jbardin
added
the
0.15-backport
update to v2.10.0
jbardin
force-pushed
the
jbardin/dynamic
branch
from
66eeebe
to
f8493bf
Compare
mildwonkey
approved these changes
Apr 21, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the new
hcldec.UnknownBodyfeature in HCL to allow unknowndynamicblocks to be decoded as entirely unknown values. A more complete description of this new feature is in hashicorp/hcl#461Now that the dynamic sentinel values are no longer a factor, the logic around
couldHaveUnknownBlockPlaceholderis no longer needed, asAssertObjectCompatiblecan directly check of the entire block container is unknown.The
hcldecpackage will also now no longer need terraform to changeMinItemsandMaxItemsto account for dynamic blocks, because they will no longer be compared at all when dealing with unknown dynamic blocks.The end result here is that providers will now be able to correctly customize (within the constraints of the Resource Instance Change Lifecycle) any proposed block values during
PlanResourceChange.Fixes #28340