backend/azurerm: Restore Azure Stack Hub support #28613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restores support for Azure Stack Hub in the azurerm remote backend. It seems that support was first broken by hashicorp#26463 and then later in hashicorp#28181 the storage package was updated to an API profile incompatible with Azure Stack Hub. I've removed the mention of `stack` as a possible value for environment in the backend configuration documentation, it fails with a validation error and doesn't seem to be in use. Resolves hashicorp#28581.
|
|
sebtelko
commented
May 5, 2021
| storageProps.AccountPropertiesCreateParameters = &armStorage.AccountPropertiesCreateParameters{ | ||
| AllowSharedKeyAccess: &allowSharedKeyAccess, | ||
| } | ||
| storageProps.AccountPropertiesCreateParameters = &armStorage.AccountPropertiesCreateParameters{} |
There was a problem hiding this comment.
I just removed this field, as it's not available in the older API profile. It doesn't seem to affect whether the test passes.
|
Is there any info on whether or not this will be merged? I can confirm that this fixed the issue for me on an Azure Stack Hub device. |
mrp02000
reviewed
Sep 15, 2021
| @@ -203,7 +203,7 @@ The following configuration options are supported: | |||
|
|
|||
| * `key` - (Required) The name of the Blob used to retrieve/store Terraform's State file inside the Storage Container. | |||
|
|
|||
| * `environment` - (Optional) The Azure Environment which should be used. This can also be sourced from the `ARM_ENVIRONMENT` environment variable. Possible values are `public`, `china`, `german`, `stack` and `usgovernment`. Defaults to `public`. | |||
| * `environment` - (Optional) The Azure Environment which should be used. This can also be sourced from the `ARM_ENVIRONMENT` environment variable. Possible values are `public`, `china`, `german` and `usgovernment`. Defaults to `public`. | |||
There was a problem hiding this comment.
Maybe keep "stack" in the docs if support is being restored?
|
Will this also fix the Hashicorp Packer tool that is experiencing similar issues with Packer connecting to Azure Public Cloud by default instead of the local Azure Stack Hub? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores support for Azure Stack Hub in the azurerm remote
backend. It seems that support was first broken by #26463 and then
later in #28181 the storage package was updated to an API profile
incompatible with Azure Stack Hub.
I've removed the mention of
stackas a possible value forenvironment in the backend configuration documentation, it fails with
a validation error and doesn't seem to be in use.
Resolves #28581.
NOTE: As is, this PR might break some of the changes that was done in #28181 to resolve #20831. I've simply verified that the azurerm backend works against Azure Stack Hub with the given changes.