Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Decode change values with marks into v0.15 #28695

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #28687 to be assessed for backporting due to the inclusion of the label 0.15-backport.

The below text is copied from the body of the original PR.


When decoding change values, the stored marks should be applied to the decoded value, as this is the direct inverse of the Encode operation. The missing marks were not noticed in most cases because they would be correctly re-evaluated on demand, however some cases like module output values can rely on the change source alone, resulting in the marks being lost during apply.

Many call sites which were aware that the marks were missing would manually apply the marks after decoding. After removing the duplicate marking and verifying tests, Decode call sites were again statically located and checked for mark handling. Any locations found that were relying on the absence of marks now must manually strip the marks before processing the values.

Fixes #28671

@teamterraform teamterraform force-pushed the backport/jbardin/sensitive-changes/mostly-working-marmot branch from 0b447c8 to 7d12bed Compare May 13, 2021 16:44
@jbardin jbardin merged commit 7487fcb into v0.15 May 13, 2021
@jbardin jbardin deleted the backport/jbardin/sensitive-changes/mostly-working-marmot branch May 13, 2021 16:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants