command/meta_backend: fix for cloud integration panic #30773
Conversation
|
|
Uk1288
changed the title
| @@ -320,6 +320,9 @@ func (m *Meta) BackendForPlan(settings plans.Backend) (backend.Enhanced, tfdiags | |||
|
|
|||
| configureDiags := b.Configure(newVal) | |||
| diags = diags.Append(configureDiags) | |||
| if configureDiags.HasErrors() { | |||
There was a problem hiding this comment.
would write this check under the configureDiags assignment before appending. Besides that awesome work... I know a small change like this must have been painful to catch! 🔥
There was a problem hiding this comment.
This is a tricky thing about how we handle diagnostics in Terraform. Because diags can contain warnings, we always append before checking for errors. This ensures that we always return diags (which may have built up a series of warnings before encountering an error), rather than writing if subDiags.HasErrors() { return subDiags } or similar.
All that to say: I think this change is actually okay, but wanted to point out that it is quite counter-intuitive.
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Uk1288
added
cloud
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Description
Currently if an error occurs during client configuration,
b.Configureit gets swallowed. This PR returns the error after it gets added to error diagnostics.Problem
Errors occurring during client configuration gets swallowed.
Fix
Fixes issue #30760
Tests
Unit tests already exists
Notes
Paired with @uturunku1