Change private to public in custom conditions example #31059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-norwood
approved these changes
May 16, 2022
There was a problem hiding this comment.
Looks good to me! AWS docs: https://docs.aws.amazon.com/vpc/latest/userguide/vpc-dns.html#vpc-dns-hostnames
Co-authored-by: Robin Norwood <rnorwood@hashicorp.com>
apparentlymart
requested review from
a team
and removed request for
apparentlymart
alisdair
approved these changes
May 17, 2022
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
laurapacilio
added a commit
that referenced
this pull request
May 19, 2022
Change private to public in custom conditions example
laurapacilio
added a commit
that referenced
this pull request
May 19, 2022
Change private to public in custom conditions example
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS always set private_dns to something, but public_dns is only set if it's enabled on the VPC. We needed to change our example from
self.private_dnstoself.public_dnsso it works correctly.Thanks to @robin-norwood for catching this!