Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to default provider configuration definition #31105

Merged

Conversation

nvanthao
Copy link
Contributor

What

I'm adding link to default provider configuration definition in Providers Within Modules page

Why

To make it clear that Implicit Provider Inheritance is inclusive of un-aliased/ omitted provider block config.
The code example in above section only mentioned about un-aliased provider config.

provider "aws" {
  region = "us-west-1"
}

module "child" {
  source = "./child"
}

@hashicorp-cla
Copy link

hashicorp-cla commented May 23, 2022

CLA assistant check
All committers have signed the CLA.

@crw
Copy link
Collaborator

crw commented May 23, 2022

Thanks for this submission!

Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a suggestion for you to review :-)

website/docs/language/modules/develop/providers.mdx Outdated Show resolved Hide resolved
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! :-)

@laurapacilio laurapacilio added the 1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jun 8, 2022
@crw
Copy link
Collaborator

crw commented Jun 15, 2022

@laurapacilio did you mean to merge this one?

@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@nvanthao nvanthao deleted the nvanthao/update-docs-implicit-provider branch June 21, 2022 03:32
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants