Apply the -chdir option before resolving implied provider filesystem mirror directories
#31443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for this submission. Although I cannot commit to having this PR reviewed at this time, we acknowledge your contribution and appreciate it! We will discuss it in our weekly triage meeting. Thanks again! |
apparentlymart
changed the title
-chdir option before resolving implied provider filesystem mirror directories
This was referenced Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Bug reported in #31442
The code to reset the current working directory was previously called after the local providers checked in
implicitProviderSource()is called.I simply moved up the block of code handling the reset of the current working directory ahead of
providerSource()which subsequently callsimplicitProviderSource().I have compiled and tested the code to verify it fixes the cited issue, but can not be 100% sure there are no other side effects from this change. I cannot think of any situation where you need to maintain the CWD when specifying
-chdir, but there could be some side effects I am not aware of.