Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax, use HCL2 expression #32431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fracampit
Copy link

Syntax in the example documentation is wrong (probably out of date). Fix syntax for assume_role.

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 22, 2022

CLA assistant check
All committers have signed the CLA.

@crw
Copy link
Collaborator

crw commented Dec 22, 2022

Thank you! I've let the docs team know to triage this PR.

Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. It looks like we need to re-indent the assume_role field, though, because it's a member of the provider block.

@@ -314,8 +314,8 @@ provider "aws" {
# No credentials explicitly set here because they come from either the
# environment or the global credentials file.

assume_role = {
role_arn = "${var.workspace_iam_roles[terraform.workspace]}"
assume_role {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assume_role {
assume_role {

I think we need to indent this field in the example because it's a part of the provider block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants