Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return early from opPlan when the plan is nil #32818

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Mar 10, 2023

While the returned plan is checked for nil in most cases, there was a single point where the plan was dereferenced which could panic. Rather than always guarding the dereferences, return early when the plan is nil.

Fixes #32810

Target Release

v1.4.1

While the returned plan is checked for nil in most cases, there was
a single point where the plan was dereferenced which could panic. Rather
than always guarding the dereferences, return early when the plan is
nil.
@jbardin jbardin added the 1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Mar 10, 2023
@jbardin jbardin requested a review from a team March 10, 2023 14:37
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime error: invalid memory address or nil pointer -- v1.4.0
3 participants