Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sum.mdx docs #33514

Merged
merged 2 commits into from Oct 13, 2023
Merged

Update sum.mdx docs #33514

merged 2 commits into from Oct 13, 2023

Conversation

AgustinRamiroDiaz
Copy link
Contributor

Explain edge case with empty list

Fixes #

Target Release

1.5.x

Draft CHANGELOG entry

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

@AgustinRamiroDiaz
Update sum.mdx docs
da2b1e0 
Explain edge case with empty list
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 12, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@crw
Copy link
Collaborator

crw commented Jul 12, 2023

Thanks for this submission! I have notified the docs team for triage.

trujillo-adam
trujillo-adam reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Just a small suggestion for consistency with our writing style.

website/docs/language/functions/sum.mdx Outdated Show resolved Hide resolved
@trujillo-adam trujillo-adam added the tw-reviewed Technical Writing has reviewed this PR. label Oct 11, 2023
@crw crw added the waiting-response An issue/pull request is waiting for a response from the community label Oct 11, 2023
@AgustinRamiroDiaz @trujillo-adam
Update website/docs/language/functions/sum.mdx
88b765d 
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
trujillo-adam
trujillo-adam approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@trujillo-adam trujillo-adam removed the waiting-response An issue/pull request is waiting for a response from the community label Oct 12, 2023
@crw crw added the 1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Oct 13, 2023
@crw crw merged commit d085783 into hashicorp:main Oct 13, 2023
6 of 7 checks passed
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@teamterraform teamterraform mentioned this pull request Oct 13, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trujillo-adam trujillo-adam trujillo-adam approved these changes

Assignees
No one assigned
Labels
1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation tw-reviewed Technical Writing has reviewed this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AgustinRamiroDiaz @hashicorp-cla @crw @trujillo-adam