Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend/s3: Adds SSO endpoint override #34195

Merged
merged 6 commits into from Nov 14, 2023
Merged

backend/s3: Adds SSO endpoint override #34195

merged 6 commits into from Nov 14, 2023

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Nov 6, 2023 •
edited

Adds S3 backend parameter endpoints.sso to override the AWS SSO API endpoint.

Closes #34142

Depends on release of hashicorp/aws-sdk-go-base#741

Target Release

1.6.4

Draft CHANGELOG entry

ENHANCEMENTS

  • backend/s3: Adds the parameter endpoints.sso to allow users to override the AWS SSO API endpoint

@gdavison gdavison added the 1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Nov 6, 2023
@radeksimko radeksimko mentioned this pull request Nov 7, 2023
Closed
@gdavison gdavison marked this pull request as ready for review November 11, 2023 08:42
@gdavison gdavison requested a review from a team as a code owner November 11, 2023 08:42
jar-b
jar-b approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 153.015s

@gdavison gdavison merged commit c018798 into main Nov 14, 2023
7 checks passed
@github-actions GitHub Actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@teamterraform teamterraform mentioned this pull request Nov 14, 2023
Merged
@jordancparker jordancparker mentioned this pull request Nov 15, 2023
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/s3 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

backend/s3: Add SSO endpoint override parameter
2 participants
@gdavison @jar-b