Add logic to collect variables for terrafrom test

[JKIPIKA]

I created the new function collectVariableValuesForTests that collects variables for the terraform test and the configuration to store and use collected values.

[hashicorp-cla]

All committers have signed the CLA.

[JKIPIKA]

#34008

[liamcervante]

Hi @JKIPIKA, this looks really good. Thanks for this.

I've added a couple comments in line, just tweaking the logic for this but overall the approach looks good.

It would also be good if you could add some tests for this. It doesn't need to be complicated:

1. Add a new directory called tfvars_in_test_dir (or something) into here: https://github.com/hashicorp/terraform/tree/main/internal/command/testdata/test
2. Create a simple configuration file that does something trivial like define some variables and echo them back as outputs.
3. Create a nested tests directory.
4. Create a variables file that should be loaded by default in the tests directory, and set values for the variables in the configuration.
5. Create a sample test file that doesn't set any of the variables, but has a run block that validates the config outputs match the values set in the default variables file.
6. Reference the tfvars_in_test_dir directory you created in step one from https://github.com/hashicorp/terraform/blob/main/internal/command/test_test.go#L33, and set the expected number of passed (1) and failed (0) tests and exit code (0).

You could repeat this to add tests to make sure any JSON variable files are loaded, or to make sure everything still works if you load an alternate test directory, if you wanted to really test things thoroughly.

Hopefully that all makes sense, let me know if you have any questions!

[JKIPIKA]

Hi @liamcervante ! Thanks for the review, ill try to add the changes that you mentioned alongside with the tests.

[JKIPIKA]

Hi @liamcervante , I hope i understood all the things that you mentioned, can you please review the new changes ?

[crw]

@JKIPIKA could you please sign the CLA? See this comment: #34276 (comment) -- this is needed for us to eventually accept the changes. Thanks! I will let @liamcervante know you've made changes per his review.

[liamcervante]

Thanks @JKIPIKA, this looks very close.

Could you also rebase your changes against main? Hopefully, we'll release this for v1.7 which means we want to merge into main rather than the v1.6 branch.

And as Craig said you'll need to sign the CLA!

Thanks!

[liamcervante]

I think this file should be in the tests directory alongside the var files.

[JKIPIKA]

Hi @liamcervante, I finished last modifications that you mentioned and signed the CLA, but can you please provide me some hints how to effectively rebase it against main, as there are a lot of conflicts ?

I cherry-picked my changes into master branch, maybe if we can change the source branch on this PR to my main branch, would be this approach more simpler ?

[liamcervante]

@JKIPIKA, I don't think we can change the base branch for the pull request, and the diff is going to be complicated now we have a merge with the latest 1.6 branch in here.

I've looked at the diff for the changes you have in your main here. I think they look very close, so maybe the best thing to do is for you to close this PR, and create a new one that is merging your changes from main into our main. We can iterate from there to close out the final things - they mostly look like changes as a result of the cherry-picking, so we'll just have to undo some things.

[JKIPIKA]

Hi, @liamcervante, I create the PR for the main branch #34341, but there are two changes which I think were done due to cherry-picking, I marked them with comment. Can it be somehow resolved ?

[liamcervante]

Closed in favour of #34341

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.