Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic when import id is empty string #34625

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix panic when import id is empty string #34625

merged 1 commit into from
Feb 7, 2024

Conversation

DanielMSchmidt
Copy link
Collaborator

@DanielMSchmidt DanielMSchmidt commented Feb 6, 2024 •
edited
Loading

We can only detect this during evaluation since the import id is an hcl expression

Fixes #33505

Target Release

1.7.x

Draft CHANGELOG entry

BUG FIXES

  • throw helpful error message if import block is configured with id ""

@DanielMSchmidt DanielMSchmidt force-pushed the throw-better-error-if-import-id-is-empty-string branch from f9b321a to 14a8009 Compare February 6, 2024 12:50
@DanielMSchmidt DanielMSchmidt force-pushed the throw-better-error-if-import-id-is-empty-string branch 2 times, most recently from 5614e92 to e0cb633 Compare February 6, 2024 15:09
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review February 6, 2024 15:10
@DanielMSchmidt DanielMSchmidt force-pushed the throw-better-error-if-import-id-is-empty-string branch from e0cb633 to a281646 Compare February 6, 2024 16:28
@DanielMSchmidt DanielMSchmidt force-pushed the throw-better-error-if-import-id-is-empty-string branch from a281646 to f56b19a Compare February 7, 2024 10:06
@DanielMSchmidt
fix panic when import id is empty string
2b7c7b2 
We can only detect this during evaluation since the import id
is an hcl expression.

Fixes #33505
@DanielMSchmidt DanielMSchmidt force-pushed the throw-better-error-if-import-id-is-empty-string branch from f56b19a to 2b7c7b2 Compare February 7, 2024 10:14
liamcervante
liamcervante approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this can be backported as well.

@DanielMSchmidt DanielMSchmidt added the 1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Feb 7, 2024
@DanielMSchmidt DanielMSchmidt merged commit 5b29b92 into main Feb 7, 2024
6 checks passed
@DanielMSchmidt DanielMSchmidt deleted the throw-better-error-if-import-id-is-empty-string branch February 7, 2024 14:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@teamterraform teamterraform mentioned this pull request Feb 7, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamcervante liamcervante liamcervante approved these changes

Assignees
No one assigned
Labels
1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import block with id of "" causes plan to error
2 participants
@DanielMSchmidt @liamcervante