Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform test: use platform independent path functions #34666

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

liamcervante
Copy link
Member

This PR updates the testing framework to use the platform independent filepath package instead of the linux-only path package. This fixes loading and processing variable values loaded from automated variable files in the testing directory.

Fixes #34664

Target Release

1.7.x

Draft CHANGELOG entry

BUG FIXES

  • terraform test: Fix automatic loading of variable files within the test directory on windows platforms.

@liamcervante liamcervante added the 1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Feb 13, 2024
@liamcervante liamcervante requested a review from a team February 13, 2024 14:42
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test for this but LGTM either way.

@liamcervante liamcervante merged commit 58289db into main Feb 13, 2024
6 checks passed
@liamcervante liamcervante deleted the liamcervante/34664 branch February 13, 2024 14:59
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

@moshahin01 moshahin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

moshahin01

This comment was marked as duplicate.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables in testing directory are not automatically loaded on Windows
3 participants