stacks: fix flaky stackruntime
tests
#34708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all the
stackruntime
tests to use the consistent sorting I introduced for some of my tests earlier.Previously, we were sorting the test outputs based on the
%T
representation of their type. If we had two events of the same type this meant the results weren't deterministic. I introduced theappliedChangeSortKey
andplannedChangeSortKey
functions in an earlier PR. These sort by the unique addresses of each event type, and so are truly deterministic.Here's an example of a flake, fixed with a retry:
I didn't think any of the other tests were producing two changes of the same type so I didn't update them previously. Now, I just blanket replaced everything.