Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacks: fix flaky stackruntime tests #34708

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

liamcervante
Copy link
Member

@liamcervante liamcervante commented Feb 20, 2024

This PR updates all the stackruntime tests to use the consistent sorting I introduced for some of my tests earlier.

Previously, we were sorting the test outputs based on the %T representation of their type. If we had two events of the same type this meant the results weren't deterministic. I introduced the appliedChangeSortKey and plannedChangeSortKey functions in an earlier PR. These sort by the unique addresses of each event type, and so are truly deterministic.

Here's an example of a flake, fixed with a retry:

I didn't think any of the other tests were producing two changes of the same type so I didn't update them previously. Now, I just blanket replaced everything.

@liamcervante liamcervante merged commit 2472f7c into main Feb 21, 2024
6 checks passed
@liamcervante liamcervante deleted the liamcervante/stacks-flakes branch February 21, 2024 09:40
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants