stacks: validate providers based on types instead of local names #34735
Conversation
There was a problem hiding this comment.
This seems plausible to me!
As usual with these things that sit on the boundary between two modules, this is kinda hard to scan and "mentally execute", but I can't think of any specific way to improve that; it's also true of the similar logic in the modules runtime for dealing with module blocks.
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Currently, stacks resolves provider types entirely by doing reverse look ups against the local name of the provider within the stack configuration. It then tries to resolve the provider map within components by looking up the provider entries by that local name. There is no guarantee that the local names between the component configs and the stack configs will match up.
This PR makes the
RequiredProviderInstanceslookup function also return theLocalProviderConfigaddress. This means we can look up the local name for the required provider in the stack configuration separately to resolving the local name within the component configuration.We also expand the static analysis so that it checks the type of the returned references (to make sure they are referencing providers). The dynamic analysis now doesn't repeat the same set of checks as the static analysis, with the providers required by the state processed separately to the configuration providers.