Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate self-references within resource count and foreach arguments #35047

Merged
merged 2 commits into from Apr 23, 2024

Conversation

liamcervante
Copy link
Member

Currently Terraform will crash if a resource references itself from the count or for_each attributes. This PR updates the expansion node for resources to perform the same check that the execution nodes perform based on "self-references. After this PR, Terraform reports a consistent error if any attributes from within a resource reference that same resource.

Fixes #35038

Target Release

1.8.2

Draft CHANGELOG entry

ENHANCEMENTS

  • Replace panic with error message when self-referencing resources and data source from the count or for_each meta attributes.

@liamcervante liamcervante requested a review from a team April 22, 2024 14:05
@liamcervante liamcervante marked this pull request as ready for review April 22, 2024 14:05
@liamcervante liamcervante added the 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Apr 22, 2024
@liamcervante liamcervante merged commit 5294d1f into main Apr 23, 2024
6 checks passed
@liamcervante liamcervante deleted the liamcervante/35038 branch April 23, 2024 07:06
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform plan crashed.
2 participants