Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config syntax docs update #35093

Merged
merged 3 commits into from May 7, 2024

Conversation

bandhan-majumder
Copy link
Contributor

Draft CHANGELOG entry

UPGRADE NOTES
  • Added information about labels "aws_instance" and "example" in resource type block.

Added information about labels "aws_instance" and "example" in the resource.
Updated information about labels "aws_instance" and "example" in the block resource type .
Copy link

hashicorp-cla-app bot commented Apr 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@crw
Copy link
Collaborator

crw commented Apr 29, 2024

Thanks for this submission! I am going to pass this one to the docs team for review.

@bandhan-majumder
Copy link
Contributor Author

Sure. Thank you!

Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this detail. I made a few tweaks to fix some grammar and style issues.

website/docs/language/syntax/configuration.mdx Outdated Show resolved Hide resolved
@trujillo-adam trujillo-adam added the tw-reviewed Technical Writing has reviewed this PR. label May 7, 2024
Fixed grammar and style issues.

Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
@bandhan-majumder
Copy link
Contributor Author

@trujillo-adam Thanks for the correction!

@crw crw added the 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label May 7, 2024
@crw crw merged commit 81f5232 into hashicorp:main May 7, 2024
6 of 7 checks passed
Copy link

github-actions bot commented May 7, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation tw-reviewed Technical Writing has reviewed this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants