Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud: terraform output should gracefully handle 503 errors #35143

Merged

Conversation

brandonc
Copy link
Contributor

@brandonc brandonc commented May 9, 2024

Fixes #35105

When outputs are not available while using cloud backend, terraform will now silently retry while logging attempts. If retries are canceled or time out after one minute, an error is displayed (See below for screenshots)

Target Release

1.9.x

Draft CHANGELOG entry

ENHANCEMENTS

  • terraform output with cloud block: terraform no longer suggests that data loss could occur when outputs are not available

Screenshots

Before:
Screenshot 2024-05-02 at 4 24 40 PM

After (With TF_LOG, canceled):
Screenshot 2024-05-06 at 11 21 45 AM

After (With TF_LOG, deadline exceeded):
Please note the actual message says "within the deadline" not actually "within the timeout"
Screenshot 2024-05-06 at 11 21 36 AM

internal/cloud/retry.go Outdated Show resolved Hide resolved
@brandonc brandonc force-pushed the TF-15181-terraform-output-should-gracefully-handle-503-errors branch from 932f5e8 to 0efd586 Compare May 13, 2024 22:37
@brandonc brandonc merged commit dc3a040 into main May 13, 2024
11 checks passed
@brandonc brandonc deleted the TF-15181-terraform-output-should-gracefully-handle-503-errors branch May 13, 2024 22:50
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform output not display the outputs
3 participants