provider/aws: Add resource.Retry to aws_internet_gateway resource creation

[stack72]

Fixes #2174. No functionality has changed here, a retry has just been added. I made 4 test runs and all worked as expected. @radeksimko this may be of use to you

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSInternetGateway' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInternetGateway -timeout 120m
=== RUN   TestAccAWSInternetGateway_basic
--- PASS: TestAccAWSInternetGateway_basic (79.97s)
=== RUN   TestAccAWSInternetGateway_delete
--- PASS: TestAccAWSInternetGateway_delete (60.20s)
=== RUN   TestAccAWSInternetGateway_tags
--- PASS: TestAccAWSInternetGateway_tags (66.98s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    207.170s

[radeksimko]

Hey Paul,
few comments on this:

1. I don't believe this is fixing provider/aws: IGW sometimes takes time to create #2174, because the error InvalidInternetGatewayID.NotFound is coming either from the Describe API call or from AttachInternetGateway or the AddTags, but surely not from Create.
2. I'm tempted to say the feature from helper: Add ContinuousTargetOccurence to work around inconsistency #4447 would be useful here, but I'd be also careful not to introduce unnecessary delays.

I think this will require having more detailed logging and an acceptance test to run in loop until you hit the error. That way we can identify which API calls need to be guarded.

[phinze]

Just noting that my work from today changed the resource.Retry interface, so this will need to be reworked to match the new one if we decide we still want to do it.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.