Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/google: support optionial uuid naming for Instance Template #6604

Merged
merged 1 commit into from May 11, 2016

Conversation

evandbrown
Copy link
Contributor

Auto-generating an Instance Template name (or just its suffix) allows the
create_before_destroy lifecycle option to function correctly on the
Instance Template resource. This in turn allows Instance Group Managers
to be updated without being destroyed.

Addresses #6234

Auto-generating an Instance Template name (or just its suffix) allows the
create_before_destroy lifecycle option to function correctly on the
Instance Template resource. This in turn allows Instance Group Managers
to be updated without being destroyed.
@phinze
Copy link
Contributor

phinze commented May 10, 2016

Nice! Can you attach test output from all the acctests for this resource? -run ^TestAccInstanceGroupManager

Code and docs look solid. 👍

@billf
Copy link
Contributor

billf commented May 10, 2016

This is a good middle ground for allowing modifications of templates without destroying IGMs.
You can achieve something similar with the uuid() interpolation function and ignoring the name attribute, but then you have to format the uuid() output each time and it gets ugly quick.

@evandbrown
Copy link
Contributor Author

@phinze yep!

$ make testacc TEST=./builtin/providers/google GOOGLE_PROJECT=evandbrown17 GOOGLE_REGION=us-central1 TESTARGS='-run=TestAccInstanceGroupManager'
==> Checking that code complies with gofmt requirements...
/home/evanbrown/dev/golang/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
2016/05/10 15:54:48 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccInstanceGroupManager -timeout 120m
=== RUN   TestAccInstanceGroupManager_basic
--- PASS: TestAccInstanceGroupManager_basic (233.67s)
=== RUN   TestAccInstanceGroupManager_update
--- PASS: TestAccInstanceGroupManager_update (198.31s)
=== RUN   TestAccInstanceGroupManager_updateLifecycle
--- PASS: TestAccInstanceGroupManager_updateLifecycle (143.55s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 575.639s

@phinze
Copy link
Contributor

phinze commented May 10, 2016

LGTM

@stack72 stack72 merged commit 55742ac into hashicorp:master May 11, 2016
cristicalin pushed a commit to cristicalin/terraform that referenced this pull request May 24, 2016
…hashicorp#6604)

Auto-generating an Instance Template name (or just its suffix) allows the
create_before_destroy lifecycle option to function correctly on the
Instance Template resource. This in turn allows Instance Group Managers
to be updated without being destroyed.
@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants