aws:Adding in retry to allow ec2/DescribeRouteTables consistency

[jrnt30]

Fixes #5335 - This adds in additional retry logic for the addition of the route. As it stands today, there have been several issues with the AWS API not returning the explicit route via ec2/DescribeRouteTables for some period of time.

The previous version just retried when the creation of the route was unsuccessful.

[catsby]

Do you know what kind of error we get when the situation you describe in #5335 happens, when a route is created but the follow up DescribeRoutes doesn't have it? I'm curious if this retry logic is better suited to be in findResourceRoute

[jrnt30]

There was no error per se. It was that the response was empty, which ultimately led to the issue being generated that the resource didn't have an id (and would fail on subsequent runs due to an overlap of CIDR blocks).

I had considered the findResourceRoute however as it stands it would also potentially impact the read operation (since we are just retrying until we actually get a response back). In the missing case, that would incur the retry cost. I could however add in an additional param around the retry if that would be more desirable.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.