Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Kinesis streams shard-level metrics #7684

Merged
merged 3 commits into from
Jul 21, 2016
Merged

Add support for Kinesis streams shard-level metrics #7684

merged 3 commits into from
Jul 21, 2016

Conversation

cbroglie
Copy link
Contributor

Fixes #7679

@cbroglie cbroglie mentioned this pull request Jul 18, 2016
Closed
@cbroglie cbroglie changed the title [WIP] Add support for Kinesis streams shard-level metrics Add support for Kinesis streams shard-level metrics Jul 21, 2016
@stack72
Copy link
Contributor

stack72 commented Jul 21, 2016 •
edited

Hi @cbroglie

This is looking good :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSKinesisStream_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSKinesisStream_ -timeout 120m
=== RUN   TestAccAWSKinesisStream_basic
--- PASS: TestAccAWSKinesisStream_basic (102.46s)
=== RUN   TestAccAWSKinesisStream_shardCount
--- PASS: TestAccAWSKinesisStream_shardCount (200.41s)
=== RUN   TestAccAWSKinesisStream_retentionPeriod
--- PASS: TestAccAWSKinesisStream_retentionPeriod (205.44s)
=== RUN   TestAccAWSKinesisStream_shardLevelMetrics
--- PASS: TestAccAWSKinesisStream_shardLevelMetrics (225.69s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    734.027s

Thanks for all the work here!

Paul

@stack72 stack72 merged commit 2505b2e into hashicorp:master Jul 21, 2016
@cbroglie
Copy link
Contributor Author

Great, thanks for your help

@cbroglie cbroglie deleted the kinesis-shard-metrics branch July 21, 2016 22:42
robinbowes added a commit to yo61/terraform that referenced this pull request Jul 25, 2016
@robinbowes
Merge branch 'master' into update_vmware-govcd
5a81e04 
* master: (34 commits)
  Update CHANGELOG.md
  provider/aws: Delete access keys before deleting IAM user (hashicorp#7766)
  Fix broken link to Consul demo (hashicorp#7789)
  provider/aws: `aws_redshift_cluster` `number_of_nodes` was having the (hashicorp#7771)
  provider/aws: Restore lost client.simpledbconn initialization
  Update vendored atlas client
  Make using `ssl_verify_mode` more robust (hashicorp#7769)
  Update CHANGELOG.md
  provider/aws: Rename the ECS Container Data Source test
  docs/azure: Small changes to remove the use of double
  Update docs to centralize on ARM-based Azure provider (hashicorp#7767)
  Update CHANGELOG.md
  Update CHANGELOG.md
  Add support for Kinesis streams shard-level metrics (hashicorp#7684)
  Update CHANGELOG.md
  Implementing aws_ami_launch_permission. (hashicorp#7365)
  Update CHANGELOG.md
  Add VersionString
  provider/aws: Set `storage_encrypted` to state in (hashicorp#7751)
  provider/fastly: Update go-fastly SDK (hashicorp#7747)
  ...
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Kinesis enhanced monitoring
2 participants
@cbroglie @stack72