Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker containerization docs #10222

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Update Docker containerization docs #10222

merged 2 commits into from
Sep 20, 2018

Conversation

zwass
Copy link
Contributor

@zwass zwass commented Sep 20, 2018

The docs indicate that most systems must use a VM for containerization. This is no longer the case as Docker For Mac now uses HyperKit.

See https://docs.docker.com/v17.12/docker-for-mac/docker-toolbox/

The docs indicate that most systems must use a VM for containerization. This is no longer the case as Docker For Mac now uses HyperKit.

See https://docs.docker.com/v17.12/docker-for-mac/docker-toolbox/
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!! Just had a quick note, but otherwise looks great! 🎉 📝

with Linux installed to provide that.
and stopping containers is extremely fast. Docker uses the native
containerization functionality on macOS and Linux, while it must start a Linux
VM for compatibility with Windows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think this line is technically false as well? You can have windows containers now https://docs.docker.com/docker-for-windows/install/#what-to-know-before-you-install
https://docs.microsoft.com/en-us/virtualization/windowscontainers/about/

I would maybe just change that last line to mention both for Windows containers and a Linux VM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point. Looks like the line should say "Docker uses the native containerization functionality on macOS, Linux, and Windows."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍Yeah that makes sense to me. Get that updated and it'll be good to merge ❤️

Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@briancain briancain merged commit 7402823 into hashicorp:master Sep 20, 2018
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants