Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add communicator reset #10399

Merged
merged 7 commits into from
Nov 13, 2018
Merged

Conversation

chrisroberts
Copy link
Member

Adds a Communicator#reset! method to allow resetting the communicator to force establishing a new connection. Fixes linux docker install to reset communicator after group updates so vagrant user has docker group available. Includes new option :reset to the shell provisioner to allow resetting the connection after a provisioner has completed. Also allows a provisioner to run without a path or inline defined simply to reset the connection.

Fixes #10388

@chrisroberts chrisroberts added this to the 2.2.1 milestone Nov 12, 2018
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ 👍 Looks good to me!

@chrisroberts chrisroberts merged commit 7efd501 into hashicorp:master Nov 13, 2018
@chrisroberts chrisroberts deleted the e-comm-reset branch November 13, 2018 17:13
@mbrodala
Copy link
Contributor

Awesome, thanks a lot!

@leighmcculloch
Copy link

Thanks @chrisroberts! That was a fast turn around! 🎉

richfitz added a commit to vimc/montagu-machine that referenced this pull request Jan 21, 2019
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use Docker as unprivileged user on first "up"
4 participants