fixes #2270, support env variables in puppet apply run

[Azulinho]

for a config of:

   config.vm.provision :puppet do |puppet|
     puppet.environment_variables = { 'FOO' => 'BAR' }
   end

it provides 'FOO' in the same execution context as the puppet apply run:

\>VAGRANT_LOG=info bundle exec vagrant provision 2>&1 | grep 'puppet apply'
 INFO ssh: Execute: FOO='BAR'   puppet apply --color=false
 --detailed-exitcodes --manifestdir
 /tmp/vagrant-puppet/manifests-a11d1078b1b1f2e3bdea27312f6ba513
 /tmp/vagrant-puppet/manifests-a11d1078b1b1f2e3bdea27312f6ba513/default.pp

this should fix #2270

[sethvargo]

Hi @Azulinho

Thank you for opening an PR. Unfortunately this will not merge cleanly and there appears to be other changes to the CFEngine provider as well. Could you please rebase and remove the unrelated changes or submit them in another PR? Thanks! 😄

[murphyj]

Any movement on this? Seems like the sort of thing you'd ideally want.

Is there a suggested workaround?

[Azulinho]

not sure how the cfengine stuff had appeared there, probably branched out some random feature branch

dropped this PR in favour of:
#7252