Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2270, support env variables in puppet apply run #7252

Closed
wants to merge 1 commit into from
Closed

fixes #2270, support env variables in puppet apply run #7252

wants to merge 1 commit into from

Conversation

Azulinho
Copy link
Contributor

@Azulinho Azulinho commented Apr 23, 2016

replaces PR #6688

for a config of:

   config.vm.provision :puppet do |puppet|
     puppet.environment_variables = { 'FOO' => 'BAR' }
   end

it provides 'FOO' in the same execution context as the puppet apply run:

\>VAGRANT_LOG=info bundle exec vagrant provision 2>&1 | grep 'puppet apply'
 INFO ssh: Execute: FOO='BAR'   puppet apply --color=false
 --detailed-exitcodes --manifestdir
 /tmp/vagrant-puppet/manifests-a11d1078b1b1f2e3bdea27312f6ba513
 /tmp/vagrant-puppet/manifests-a11d1078b1b1f2e3bdea27312f6ba513/default.pp

this should fix #2270

@sethvargo
Copy link
Contributor

Hi @Azulinho

Thank you for opening a Pull Request. In reviewing the code, it looks like this is only adding the configuration option. I'm not seeing where the environment variables are actually used in the provisioner. Did you miss a few files to commit?

@chrisroberts chrisroberts added this to the Floating milestone Oct 5, 2016
@chrisroberts
Copy link
Member

Hey there,

I am going to close this due to lack of response. If this is still occurring, please open a new issue and follow the provided issue template that appears when you click the "New Issue" button. This will help us in getting a reproduction and fix. Thanks! 😄

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing Environment Variables through to Puppet Apply
3 participants