Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #7610 (incorrect permissions on ~/.ssh/authorized_keys causes authentication failure after insecure keypair replacement) #7611

Merged
merged 3 commits into from Jul 20, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/guests/linux/cap/public_key.rb
Expand Up @@ -38,7 +38,7 @@ def self.remove_public_key(machine, contents)
contents = contents.strip << "\n"

remote_path = "/tmp/vagrant-remove-pubkey-#{Time.now.to_i}"
Tempfile.open("vagrant-bsd-remove-public-key") do |f|
Tempfile.open("vagrant-linux-remove-public-key") do |f|
f.binmode
f.write(contents)
f.fsync
Expand All @@ -54,6 +54,7 @@ def self.remove_public_key(machine, contents)
if test -f ~/.ssh/authorized_keys; then
grep -v -x -f '#{remote_path}' ~/.ssh/authorized_keys > ~/.ssh/authorized_keys.tmp
mv ~/.ssh/authorized_keys.tmp ~/.ssh/authorized_keys
chmod 0600 ~/.ssh/authorized_keys
fi

rm -f '#{remote_path}'
Expand Down
32 changes: 32 additions & 0 deletions test/unit/plugins/guests/linux/cap/remove_public_key_test.rb
@@ -0,0 +1,32 @@
require_relative "../../../../base"

describe "VagrantPlugins::GuestLinux::Cap::RemovePublicKey" do
let(:caps) do
VagrantPlugins::GuestLinux::Plugin
.components
.guest_capabilities[:linux]
end

let(:machine) { double("machine") }
let(:comm) { VagrantTests::DummyCommunicator::Communicator.new(machine) }

before do
allow(machine).to receive(:communicate).and_return(comm)
end

after do
comm.verify_expectations!
end

describe ".remove_public_key" do
let(:cap) { caps.get(:remove_public_key) }

it "removes the public key" do
cap.remove_public_key(machine, "ssh-rsa ...")
expect(comm.received_commands[0]).to match(/grep -v -x -f '\/tmp\/vagrant-(.+)' ~\/\.ssh\/authorized_keys > ~\/.ssh\/authorized_keys\.tmp/)
expect(comm.received_commands[0]).to match(/mv ~\/.ssh\/authorized_keys\.tmp ~\/.ssh\/authorized_keys/)
expect(comm.received_commands[0]).to match(/chmod 0600 ~\/.ssh\/authorized_keys/)
expect(comm.received_commands[0]).to match(/rm -f '\/tmp\/vagrant-(.+)'/)
end
end
end