Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use node16 for the action #375

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

prizov
Copy link
Contributor

@prizov prizov commented Oct 12, 2022

Addresses #373

What

The PR sets node16 as a runtime in the action.yaml file.

This version is already being used for building and testing the action thus the change shouldn't have any side effects

Why

GitHub Actions: All Actions will begin running on Node16 instead of Node12

We plan to migrate all actions to run on Node16 by Summer 2023. We will monitor the progress of the migration and listen to the community for how things are going before we define a final date.
To raise awareness of the upcoming change, we are adding a warning into workflows which contain Actions running on Node 12. This will come into effect starting on September 27th.

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 12, 2022

CLA assistant check
All committers have signed the CLA.

@heatherezell heatherezell added the dependencies Pull requests that update a dependency file label Oct 12, 2022
Copy link

@bfaulk96 bfaulk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval means nothing since I'm not a maintainer, but approving anyways as a +1

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution to HashiCorp!

@vinay-gopalan vinay-gopalan merged commit 2537991 into hashicorp:main Oct 13, 2022
@austingebauer austingebauer mentioned this pull request Nov 8, 2022
TomNorth pushed a commit to TomNorth/vault-action that referenced this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants