Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Secret/Auth #133

Merged
merged 12 commits into from
Jul 24, 2023
Merged

Add AWS Secret/Auth #133

merged 12 commits into from
Jul 24, 2023

Conversation

ltcarbonell
Copy link
Contributor

Add benchmark tests for AWS Secret and Auth Engines

@ltcarbonell ltcarbonell requested a review from a team as a code owner July 12, 2023 17:46
@ltcarbonell ltcarbonell requested review from jasonodonnell and elliesterner and removed request for a team July 12, 2023 17:46
ltcarbonell and others added 3 commits July 20, 2023 11:11
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Copy link
Contributor

@elliesterner elliesterner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

Copy link
Contributor

@davidadeleon davidadeleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tiny things, but otherwise looks great!

docs/tests/auth-aws.md Outdated Show resolved Hide resolved
docs/tests/auth-jwt.md Outdated Show resolved Hide resolved
ltcarbonell and others added 3 commits July 24, 2023 09:27
Co-authored-by: davidadeleon <56207066+davidadeleon@users.noreply.github.com>
Co-authored-by: davidadeleon <56207066+davidadeleon@users.noreply.github.com>
Co-authored-by: davidadeleon <56207066+davidadeleon@users.noreply.github.com>
@elliesterner
Copy link
Contributor

oh one question though! in the docs it says it supports two auth types ec2 and iam. Does this support ec2?

miagilepner and others added 3 commits July 24, 2023 11:27
include action in kvv2 builder
* rebase

* add getSignedJwt function

* add back context

* add randomness to signin

* updgrade deps

* add documentation

* remove ldap ref

* switch position

* fix spacing

* replace func

* fix params

* make sure proper token is signed based on iam vs gce

* Update benchmarktests/target_auth_gcp.go

Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com>

* Update benchmarktests/target_auth_gcp.go

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>

* Update benchmarktests/target_auth_gcp.go

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>

* cleanup config

* fix name

---------

Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com>
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
@ltcarbonell ltcarbonell merged commit 063373a into main Jul 24, 2023
26 checks passed
@ltcarbonell ltcarbonell deleted the aws-auth branch July 24, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants