-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS Secret/Auth #133
Add AWS Secret/Auth #133
Conversation
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few tiny things, but otherwise looks great!
Co-authored-by: davidadeleon <56207066+davidadeleon@users.noreply.github.com>
Co-authored-by: davidadeleon <56207066+davidadeleon@users.noreply.github.com>
Co-authored-by: davidadeleon <56207066+davidadeleon@users.noreply.github.com>
oh one question though! in the docs it says it supports two auth types |
include action in kvv2 builder
* rebase * add getSignedJwt function * add back context * add randomness to signin * updgrade deps * add documentation * remove ldap ref * switch position * fix spacing * replace func * fix params * make sure proper token is signed based on iam vs gce * Update benchmarktests/target_auth_gcp.go Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com> * Update benchmarktests/target_auth_gcp.go Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com> * Update benchmarktests/target_auth_gcp.go Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com> * cleanup config * fix name --------- Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com> Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
Add benchmark tests for AWS Secret and Auth Engines