Helm 3 support #195
Merged
Helm 3 support #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tvoran
commented
Feb 3, 2020
•
tvoran
commented
- unit tests passing
- acceptance tests passing
Staying with v1 for now, the testing instructions are already in CONTRIBUTING.md, and updating the helm install script url.
Updated injector tests and fixed other unit tests that were failing with helm 3. Following the `|| echo "---")` pattern for tests that generate empty yaml.
This was referenced Feb 3, 2020
|
@tvoran I think you need to bump the Chart API version to v2 as well. |
JulienBreux
approved these changes
Feb 6, 2020
| @@ -1,4 +1,4 @@ | |||
| apiVersion: v1 | |||
| apiVersion: v2 | |||
| name: vault | |||
There was a problem hiding this comment.
Suggested change
| name: vault | |
| name: vault | |
| type: application |
There was a problem hiding this comment.
Thanks for the review! I think we'll leave this out for now since it looks like application is the default.
jasonodonnell
approved these changes
Feb 6, 2020
Closed
radudd
pushed a commit
to radudd/vault-helm
that referenced
this pull request
Jun 5, 2020
Update chart and tests to Helm 3 Co-authored-by: Matt Piekunka <mpiekunk@users.noreply.github.com> Co-authored-by: Mike Brancato <mbrancato@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.